Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/parser): Handle async in for...of #5646

Merged
merged 8 commits into from
Aug 27, 2022
Merged

fix(es/parser): Handle async in for...of #5646

merged 8 commits into from
Aug 27, 2022
+198 −45

Conversation

magic-akari
Copy link
Member

Invalid:

for (async of []) {}

Valid

 for await (async of []) {}

@magic-akari magic-akari marked this pull request as ready for review August 27, 2022 02:30
@magic-akari magic-akari marked this pull request as draft August 27, 2022 02:32
@magic-akari magic-akari marked this pull request as ready for review August 27, 2022 02:42
@kdy1 kdy1 added this to the Planned milestone Aug 27, 2022
@magic-akari
Copy link
Member Author

magic-akari commented Aug 27, 2022 •
edited
Loading

I am thinking about for( async of =>.

tc39/ecma262#2034

@magic-akari magic-akari marked this pull request as draft August 27, 2022 04:16
@magic-akari magic-akari marked this pull request as ready for review August 27, 2022 07:47
kdy1
kdy1 approved these changes Aug 27, 2022
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

swc-bump:

  • swc_ecma_parser

@kdy1 kdy1 enabled auto-merge (squash) August 27, 2022 15:10
swc-bot
swc-bot reviewed Aug 27, 2022
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 0f0d1db into swc-project:main Aug 27, 2022
@kdy1 kdy1 modified the milestones: Planned, v1.2.245 Aug 30, 2022
@magic-akari magic-akari deleted the fix/for-of-async branch September 3, 2022 07:50
@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.2.245
Development

Successfully merging this pull request may close these issues.
3 participants
@magic-akari @kdy1 @swc-bot