-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: resolve unresolved schemas #9629
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
2dfea62
fix: resolve unresolved schemas
glowcloud c0d6edb
test: add an end-to-end test
glowcloud e2626ce
chore(deps): bump swagger-client from 3.25.0 to 3.25.3
glowcloud cc17caf
fix: change unresolved allOf rendering
glowcloud 80f68bb
fix(test): update oas3 selectors test
glowcloud 55cbe8c
fix: check if resolved schema is a map
glowcloud 76fe7e3
Merge branch 'master' into issue-9513
glowcloud File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37 changes: 37 additions & 0 deletions
37
test/e2e-cypress/e2e/features/plugins/oas3/complex-spec.cy.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
/** | ||
* @prettier | ||
*/ | ||
|
||
describe("OpenAPI 3.0 complex spec with allOf and nested references", () => { | ||
it("should render nested references", () => { | ||
cy.visit("/?url=/documents/features/oas3-complex-spec.json").then(() => { | ||
cy.get( | ||
"[id='model-com.sap.ctsm.backend.core.api.study.v1.StudyAPIv1.StudyTreatments-create']" | ||
) | ||
.find("button") | ||
.click() | ||
cy.get(".property-row") | ||
.contains("scenario") | ||
.siblings() | ||
.as("scenarioSiblings") | ||
cy.get("@scenarioSiblings").find("button").click() | ||
cy.get("@scenarioSiblings") | ||
.find("span") | ||
.contains("scenarioID") | ||
.should("not.exist") | ||
cy.get("@scenarioSiblings") | ||
.find("span") | ||
.contains("Scenarios (for create)") | ||
.should("exist") | ||
.click() | ||
cy.get("@scenarioSiblings") | ||
.find("span") | ||
.contains("scenarioID") | ||
.should("exist") | ||
cy.get("@scenarioSiblings") | ||
.find("span") | ||
.contains("#/components/schemas/unresolvedRef") | ||
.should("exist") | ||
}) | ||
}) | ||
}) |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can fail if
allOf
will be defined as anything else than array. But seeing theanyOf
andoneOf
, let's accept that just for consistency. We can fix that in a follow up PR for every*Of
keyword.