-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: resolve unresolved schemas #9629
Conversation
: <tr> | ||
<td>{ "allOf ->" }</td> | ||
<td> | ||
{allOf.map((schema, k) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can fail if allOf
will be defined as anything else than array. But seeing the anyOf
and oneOf
, let's accept that just for consistency. We can fix that in a follow up PR for every *Of
keyword.
src/core/components/model.jsx
Outdated
if ($ref) { | ||
name = this.getModelName($ref) | ||
const refSchema = this.getRefSchema(name) | ||
if (refSchema) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (refSchema) { | |
if (Map.isMap(refSchema)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please have a look at my suggestions before merging.
Refs #9513