Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw API error when Request Body fails to parse #311

Merged
merged 1 commit into from
Aug 30, 2019

Conversation

rvesse
Copy link
Contributor

@rvesse rvesse commented May 21, 2019

There is a bug in the implementation of OpenAPIOperationController.apply() that means that it doesn't enforce a required request body in the case where a request body is supplied but is in an unsupported MIME type. This adds the necessary else branch to the logic to throw an error in the case of a present but unsupported format request body.

There is a bug in the implemenetation of
OpenAPIOperationController.apply() that means that it doesn't enforce a
required request body in the case where a request body is supplied but
is in an unsupported MIME type.  This adds the necessary else branch to
the logic to throw an error in the case of a present but unsupported
format request body.
@frantuma frantuma merged commit 0cce488 into swagger-api:2.0 Aug 30, 2019
@frantuma
Copy link
Member

Thanks!

@rvesse
Copy link
Contributor Author

rvesse commented Sep 3, 2019

@frantuma Thanks for merging, if you get chance I have another simple PR #312 which I'd also love to see merged

@rvesse rvesse deleted the bad-request-body branch September 3, 2019 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants