Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dump parser warnings at startup #310

Merged
merged 1 commit into from
May 21, 2019

Conversation

rvesse
Copy link
Contributor

@rvesse rvesse commented May 21, 2019

When starting up Inflector if there are any warning messages emitted by the parser dump them to as WARN level log messages so that users actually see them.

This is an enhancement to help avoid issues like #309 where users like myself waste a bunch of time debugging apparently correct specifications because Inflector is simply ignoring the parser warnings�. If the parser warnings had been logged from the start I could likely have spotted and corrected the root cause much faster.

When starting up Inflector if there are any warning messages emitted by
the parser dump them to as WARN level log messages so that users
actually see them
@gracekarina gracekarina merged commit ade51f4 into swagger-api:2.0 May 21, 2019
@gracekarina
Copy link
Contributor

thanks @rvesse

@rvesse
Copy link
Contributor Author

rvesse commented May 30, 2019

@gracekarina Thanks for merging this, any chance you could also review my other PRs #311 and #312 which are other minor issues I've found using the library

@rvesse rvesse deleted the dump-parser-warnings branch May 30, 2019 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants