feat(moveElemsAttrsToGroup): improve attribute flow #1895
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes there is a
svg
or ag
that has a redundant attribute, like this:These can be removed.
And sometimes the defaults are inefficient, like this:
The default can be changed to something more efficient. This PR does that.
* This would be even better if it moved attributes from/to
svg
, but I'm not sure if I should implement that.* If the default-changing is too much, I'm fine removing everything except for the redundant attribute remover.
Results
Join this with #1894 for better performance on icon sets. On Isometric Madness compared to current SVGO, this does -3221 bytes without multipass and -4343 with.