Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tslib and use importHelpers - fixes #919 #920

Merged
merged 1 commit into from
Nov 12, 2017
Merged

add tslib and use importHelpers - fixes #919 #920

merged 1 commit into from
Nov 12, 2017
+565 −367

Conversation

Rich-Harris
Copy link
Member

TypeScript 2.6 changes the behaviour of tagged template literals. The upshot is that we need to import __makeTemplateObject from tslib, by using the importHelpers option

@Rich-Harris Rich-Harris merged commit 70750a9 into master Nov 12, 2017
@Rich-Harris Rich-Harris deleted the gh-919 branch November 12, 2017 19:36
@Conduitry
Copy link
Member

I see tslib was added as atodependencies and not devDependencies - was this in error, or can it not be bundled for some reason?

@Rich-Harris
Copy link
Member Author

Just me being careless 😬 It bundles perfectly

@fcrozatier fcrozatier mentioned this pull request Jul 8, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rich-Harris @Conduitry