Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest semver-matching dependencies fail unit tests #919

Closed
Conduitry opened this issue Nov 12, 2017 · 0 comments
Closed

Latest semver-matching dependencies fail unit tests #919

Conduitry opened this issue Nov 12, 2017 · 0 comments

Comments

@Conduitry
Copy link
Member

If you currently install dependencies with npm install, many (all?) of the unit tests fail with ReferenceError: __makeTemplateObject is not defined. Installing with Yarn is fine, as that always gives the same versions for every package.

This is inconvenient for contributors, but also currently makes CI jobs fail. We should probably figure out what happened recently with npm packages. Probably we should also make the CI jobs install using Yarn instead of npm, even though that would make situations like this possibly harder to spot right away.

Rich-Harris added a commit that referenced this issue Nov 12, 2017
add tslib and use importHelpers - fixes #919
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant