Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

site: add view transitions and transition blog title #9164

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

geoffrich
Copy link
Member

This PR adds view transitions to the site (see #9162)

Screen.Recording.2023-08-31.at.6.59.45.AM.mov

@changeset-bot
Copy link

changeset-bot bot commented Aug 31, 2023

⚠️ No Changeset found

Latest commit: cac6134

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

import '@sveltejs/site-kit/styles/index.css';

export let data;

onNavigate((navigation) => {
Copy link
Contributor

@gtm-nayan gtm-nayan Aug 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need a from-to check? IIUC it'll apply to all navigations under this layout otherwise, but animating the whole page if there's nothing with a name right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, by default it will do a fade in / fade out. Just pushed a commit to move that to a /blog layout so it only applies to navigations under those routes.

}
}

export {};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oop, just saw this thing, @dummdidumm IIRC this export make it not ambient or something along those lines right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, it's necessary for that reason. i forget why exactly

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reason here: sveltejs/kit#8276

@Rich-Harris Rich-Harris merged commit 2188035 into master Aug 31, 2023
@Rich-Harris Rich-Harris deleted the grich/blog-transitions branch August 31, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants