-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
site: add view transitions and transition blog title #9164
Conversation
|
import '@sveltejs/site-kit/styles/index.css'; | ||
|
||
export let data; | ||
|
||
onNavigate((navigation) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need a from-to check? IIUC it'll apply to all navigations under this layout otherwise, but animating the whole page if there's nothing with a name right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, by default it will do a fade in / fade out. Just pushed a commit to move that to a /blog
layout so it only applies to navigations under those routes.
} | ||
} | ||
|
||
export {}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oop, just saw this thing, @dummdidumm IIRC this export make it not ambient or something along those lines right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, it's necessary for that reason. i forget why exactly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reason here: sveltejs/kit#8276
This PR adds view transitions to the site (see #9162)
Screen.Recording.2023-08-31.at.6.59.45.AM.mov