Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

site: add view transitions blog post #9162

Merged
merged 3 commits into from
Aug 31, 2023
Merged

site: add view transitions blog post #9162

merged 3 commits into from
Aug 31, 2023

Conversation

geoffrich
Copy link
Member

New blog post talking about onNavigate and view transitions.

Depends on sveltejs/assets#6

@changeset-bot
Copy link

changeset-bot bot commented Aug 31, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: add7d82

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

geoffrich
geoffrich commented Aug 31, 2023
View reviewed changes
Copy link
Member Author

@geoffrich geoffrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming these are the correct URLs once sveltejs/assets#6 is merged (copied from "zero-effort type safety" post)

documentation/blog/2023-08-31-view-transitions.md Outdated Show resolved Hide resolved
documentation/blog/2023-08-31-view-transitions.md Outdated Show resolved Hide resolved
documentation/blog/2023-08-31-view-transitions.md Outdated Show resolved Hide resolved
geoffrich
geoffrich commented Aug 31, 2023
View reviewed changes
documentation/blog/2023-08-31-view-transitions.md

```js
// @errors: 2305 7006 2339 2810
import { onNavigate } from '$app/navigation';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a dealbreaker, but I couldn't figure out how to get the right types on hover here
image

@geoffrich geoffrich mentioned this pull request Aug 31, 2023
Merged
dummdidumm
dummdidumm approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(approving so you can merge once everything's ready)

@Rich-Harris Rich-Harris merged commit 0041f11 into master Aug 31, 2023
@Rich-Harris Rich-Harris deleted the grich/view-transitions branch August 31, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dummdidumm dummdidumm dummdidumm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@geoffrich @dummdidumm @Rich-Harris