Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade version of jsdom used in tests #6202

Merged
merged 2 commits into from
Apr 19, 2021
Merged

Upgrade version of jsdom used in tests #6202

merged 2 commits into from
Apr 19, 2021

Conversation

benmccann
Copy link
Member

@benmccann benmccann commented Apr 16, 2021

It looks like version 16 won't work because it drops Node 8 support, so upgrading to the latest version of Node 15 instead

This depends on #6074 though

@theodorejb
Copy link
Contributor

theodorejb commented Apr 18, 2021

I made this same dependency update in PR #6170. I'm hoping someone can review it soon.

@benmccann benmccann merged commit f322e3f into sveltejs:master Apr 19, 2021
@benmccann benmccann deleted the jsdom branch April 19, 2021 19:18
@benmccann
Copy link
Member Author

@theodorejb I merged this so you should be able to rebase you PR against master now and drop package.json and package-lock.json from it to make it a bit smaller

@theodorejb
Copy link
Contributor

@benmccann Thanks! I rebased my PR now.

sthagen added a commit to sthagen/sveltejs-svelte that referenced this pull request Apr 20, 2021
Upgrade version of jsdom used in tests (sveltejs#6202)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants