-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Figure out npm v7 and lockfileVersion 2 #6074
Comments
The v2 file is backwards compatible with the v1 file (perhaps that's why it's larger?). I can't imagine the size of it really matters. I'd say we just go ahead and upgrade |
I remember running into other issues before too, like none of the node_modules/.bin files being created, although I can't seem to reproduce that now. I'd like to take another look at that first at least. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
For the time being I've taken to running |
I remember running into a similar issue, where I was the one messing up the lockfile, but as someone pointed out in the resulting conversation, you can use |
Through the passage of time, I've stopped really caring about this. I'm fine if we want to upgrade to lockfile v2. |
Don't have to tell me twice: #6614 |
Running
npm install
with npm 7 on the repo currently doubles the length of the lockfile as part of converting it to version 2. I'm not sure what's going on here. When I just had to add a new dependency, I ended up manually editing some of the changes to the lockfile back out. At leastnpm ci
with npm v7 seems to leave things unchanged.(Maybe this is a good opportunity to switch to using pnpm?)
The text was updated successfully, but these errors were encountered: