Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out npm v7 and lockfileVersion 2 #6074

Closed
Conduitry opened this issue Mar 11, 2021 · 10 comments · Fixed by #6614
Closed

Figure out npm v7 and lockfileVersion 2 #6074

Conduitry opened this issue Mar 11, 2021 · 10 comments · Fixed by #6614
Labels

Comments

@Conduitry
Copy link
Member

Running npm install with npm 7 on the repo currently doubles the length of the lockfile as part of converting it to version 2. I'm not sure what's going on here. When I just had to add a new dependency, I ended up manually editing some of the changes to the lockfile back out. At least npm ci with npm v7 seems to leave things unchanged.

(Maybe this is a good opportunity to switch to using pnpm?)

@Conduitry Conduitry added the meta label Mar 11, 2021
@benmccann
Copy link
Member

The v2 file is backwards compatible with the v1 file (perhaps that's why it's larger?). I can't imagine the size of it really matters. I'd say we just go ahead and upgrade

@Conduitry
Copy link
Member Author

I remember running into other issues before too, like none of the node_modules/.bin files being created, although I can't seem to reproduce that now. I'd like to take another look at that first at least.

@Conduitry Conduitry changed the title Figure out npm v2 and lockfileVersion 2 Figure out npm v7 and lockfileVersion 2 Mar 12, 2021
@MrBigBanks

This comment has been minimized.

@MrBigBanks

This comment has been minimized.

@MrBigBanks

This comment has been minimized.

@MrBigBanks

This comment has been minimized.

@benmccann
Copy link
Member

For the time being I've taken to running npm install -g npm@6 when working on Svelte and then npm install -g npm@latest when I'm done so I can go back to working on my other projects. This is a painfully stupid workflow but at least I'm unblocked

@MeerBiene
Copy link

I remember running into a similar issue, where I was the one messing up the lockfile, but as someone pointed out in the resulting conversation, you can use npm ci to make it respect the lockfile

@Conduitry
Copy link
Member Author

Through the passage of time, I've stopped really caring about this. I'm fine if we want to upgrade to lockfile v2.

@benmccann
Copy link
Member

Don't have to tell me twice: #6614

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants