-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
invalidate $$props or $$restProps only when there's changes #5123
Conversation
52863a6
to
a65088c
Compare
@tanhauhau What do you think about only including this extra check if the component uses |
I was thinking whether the early return can skip the rest of props dirty checking, but I guess less code is worth the trade off? |
Yeah, I'm not sure. In cases where we just have the one prop being checked for, the extra In what sorts of situations might |
when a InlineComponent has dynamic attribute, it will always call the |
152516e
to
4756954
Compare
* upstream/master: (190 commits) invalidate $$props and $$restProps only when there are changes (sveltejs#5123) site: use https in link in blog (sveltejs#5148) Simplify each block bindings example (sveltejs#5094) fix $$props reactive for slots (sveltejs#5125) site: add FAQ entry for how to document a svelte component (sveltejs#5131) site: remove an obsolete TODO in blog post (sveltejs#5135) Increase timeout for unit build Increase timeout for unit tests -> v3.24.0 spread condition for input element (sveltejs#5004) update changelog fix(5018): compare wholeText instead of data (sveltejs#5028) html anchor in head (sveltejs#5071) error on expression scope store (sveltejs#5079) update changelog preprocess self-closing script and style tags (sveltejs#5082) update changelog fix: Parameters with default values are optional (sveltejs#5083) make builds time out after a reasonable period (sveltejs#5100) site: fix blog typo (sveltejs#5090) ...
* master: (67 commits) add updating guard to binding callback (sveltejs#5126) Bump lodash from 4.17.15 to 4.17.19 (sveltejs#5152) Bump lodash from 4.17.15 to 4.17.19 in /site (sveltejs#5155) Fixes sveltejs#5153 (sveltejs#5154) invalidate $$props and $$restProps only when there are changes (sveltejs#5123) site: use https in link in blog (sveltejs#5148) Simplify each block bindings example (sveltejs#5094) fix $$props reactive for slots (sveltejs#5125) site: add FAQ entry for how to document a svelte component (sveltejs#5131) site: remove an obsolete TODO in blog post (sveltejs#5135) Increase timeout for unit build Increase timeout for unit tests -> v3.24.0 spread condition for input element (sveltejs#5004) update changelog fix(5018): compare wholeText instead of data (sveltejs#5028) html anchor in head (sveltejs#5071) error on expression scope store (sveltejs#5079) update changelog preprocess self-closing script and style tags (sveltejs#5082) ...
Fixes #4993
Fixes #5118
Before submitting the PR, please make sure you do the following
npm run lint
!)Tests
npm test
oryarn test
)