Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrapping of buttons in REPL (.app-controls) #5153

Closed
Wolfr opened this issue Jul 16, 2020 · 0 comments
Closed

Wrapping of buttons in REPL (.app-controls) #5153

Wolfr opened this issue Jul 16, 2020 · 0 comments

Comments

@Wolfr
Copy link
Contributor

Wolfr commented Jul 16, 2020

Buttons don't appear on the same line in Safari Mobile:

image

This is especially apparent when viewing a REPL on iOS on an iPhone 8/iPhone SE.

This be fixed by adding a rule of white-space: nowrap on .app-controls.

image

I will send a PR referencing this issue number.
Wolfr added a commit to Wolfr/svelte that referenced this issue Jul 16, 2020
@Wolfr
Fixes sveltejs#5153
d4e0680
@Wolfr Wolfr mentioned this issue Jul 16, 2020
Merged
@antony antony closed this as completed in b54538e Jul 17, 2020
@Wolfr Wolfr mentioned this issue Jul 18, 2020
Closed
hontas added a commit to hontas/svelte that referenced this issue Jul 18, 2020
@hontas
Merge remote-tracking branch 'upstream/master'
297dfcc 
* upstream/master:
  add updating guard to binding callback (sveltejs#5126)
  Bump lodash from 4.17.15 to 4.17.19 (sveltejs#5152)
  Bump lodash from 4.17.15 to 4.17.19 in /site (sveltejs#5155)
  Fixes sveltejs#5153 (sveltejs#5154)
hontas added a commit to hontas/svelte that referenced this issue Jul 18, 2020
@hontas
Merge branch 'master' into feature/custom-element-destroy
8fc8c81 
* master: (67 commits)
  add updating guard to binding callback (sveltejs#5126)
  Bump lodash from 4.17.15 to 4.17.19 (sveltejs#5152)
  Bump lodash from 4.17.15 to 4.17.19 in /site (sveltejs#5155)
  Fixes sveltejs#5153 (sveltejs#5154)
  invalidate $$props and $$restProps only when there are changes (sveltejs#5123)
  site: use https in link in blog (sveltejs#5148)
  Simplify each block bindings example (sveltejs#5094)
  fix $$props reactive for slots (sveltejs#5125)
  site: add FAQ entry for how to document a svelte component (sveltejs#5131)
  site: remove an obsolete TODO in blog post (sveltejs#5135)
  Increase timeout for unit build
  Increase timeout for unit tests
  -> v3.24.0
  spread condition for input element (sveltejs#5004)
  update changelog
  fix(5018): compare wholeText instead of data (sveltejs#5028)
  html anchor in head (sveltejs#5071)
  error on expression scope store (sveltejs#5079)
  update changelog
  preprocess self-closing script and style tags (sveltejs#5082)
  ...
Truffula pushed a commit to Truffula/svelte that referenced this issue Aug 3, 2020
@Wolfr @Truffula
Fixes sveltejs#5153 (sveltejs#5154)
269354a
taylorzane pushed a commit to taylorzane/svelte that referenced this issue Dec 17, 2020
@Wolfr @taylorzane
Fixes sveltejs#5153 (sveltejs#5154)
dc9745c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Wolfr @mindrones