Don't generate code for a non-updating if block #3478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conduitry
reviewed
Sep 3, 2019
| @transition_in(${name}, 1);`} | ||
| } | ||
| `; | ||
| if (!branch.dependencies || branch.dependencies.length > 0) { |
There was a problem hiding this comment.
When is branch.dependencies falsy? It seems weird to do something when it's falsy or it's a non-empty array.
There was a problem hiding this comment.
It's falsy when the condition is simple (e.g. {#if foo}). I've changed that so that it's always there — makes a bit more sense now
Codecov Report
@@ Coverage Diff @@
## master #3478 +/- ##
=======================================
Coverage 50.25% 50.25%
=======================================
Files 1 1
Lines 197 197
=======================================
Hits 99 99
Misses 98 98Continue to review full report at Codecov.
|
Conduitry
approved these changes
Sep 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #3452, fixes #3447. Marking WIP because there's a case this doesn't fix