Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed complex {#if} behaviour #3452

Closed
wants to merge 1 commit into from
Closed

Fixed complex {#if} behaviour #3452

wants to merge 1 commit into from

Conversation

almaz-khan
Copy link
Contributor

Fix for #3447

@codecov-io
Copy link

codecov-io commented Aug 22, 2019

Codecov Report

Merging #3452 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3452   +/-   ##
=======================================
  Coverage   50.25%   50.25%           
=======================================
  Files           1        1           
  Lines         197      197           
=======================================
  Hits           99       99           
  Misses         98       98

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64c56ed...04d762d. Read the comment docs.

@Rich-Harris
Copy link
Member

Thanks! We can actually go further and avoid generating any update code at all in these situations — 334323f. I'll close this in favour of #3478 (which is a branch off of this one)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants