Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix request animation frame context #3016

Merged
merged 4 commits into from
Jun 16, 2019
Merged

Fix request animation frame context #3016

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b05842c
Make sure requestAnimationFrame has the correct context when triggered
johman10 Jun 12, 2019
7a89c78
Fix specs
johman10 Jun 12, 2019
6c01c27
Move from apply to call
johman10 Jun 13, 2019
049973e
simplify
Conduitry Jun 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/runtime/internal/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ export function once(fn) {
if (ran) return;
ran = true;
fn.call(this, ...args);
}
};
}

const is_client = typeof window !== 'undefined';
Expand All @@ -96,7 +96,9 @@ export let now: () => number = is_client
? () => window.performance.now()
: () => Date.now();

export let raf = is_client ? requestAnimationFrame : noop;
export let raf = (callback) => is_client && window.requestAnimationFrame
? window.requestAnimationFrame.apply(window, callback)
Conduitry marked this conversation as resolved.
Show resolved Hide resolved
: undefined;
Conduitry marked this conversation as resolved.
Show resolved Hide resolved

// used internally for testing
export function set_now(fn) {
Expand Down