Fix request animation frame context #3016
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes: #2933
Issue has been in place since 3.4.3 and later, 3.4.2 is working as expected.
Reproduction of the issue can be found here:
Check the console of the browser to see the error mentioned.
Basically the requestAnimationFrame is extracted from the window, which gives it the wrong context when triggered during animation time. The context when triggering a requestAnimationFrame should always be the window. So binding it when reassigning it fixes this issue.
I haven't added tests to cover for this change. I'm not sure how to approach that, anyone that can help me and figure that out?