Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alternative approach to #1399 #1405

Merged
merged 6 commits into from
May 3, 2018
Merged

alternative approach to #1399 #1405

merged 6 commits into from
May 3, 2018

Conversation

Rich-Harris
Copy link
Member

see discussion on #1399

btakita and others added 4 commits May 1, 2018 21:20
Store - Cyclical Dependency Detected when child computed property defined before parent & grand-parent computed proprety
@Rich-Harris Rich-Harris mentioned this pull request May 2, 2018
@codecov-io
Copy link

codecov-io commented May 2, 2018

Codecov Report

Merging #1405 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1405   +/-   ##
=======================================
  Coverage   91.25%   91.25%           
=======================================
  Files         122      122           
  Lines        4485     4485           
  Branches     1385     1385           
=======================================
  Hits         4093     4093           
  Misses        154      154           
  Partials      238      238

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ec21f7...367f062. Read the comment docs.

@Rich-Harris Rich-Harris merged commit 8eb327b into master May 3, 2018
@Rich-Harris Rich-Harris deleted the gh-1399-alt branch May 3, 2018 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants