Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues/1399 #1400

Closed
wants to merge 2 commits into from
Closed

Fix issues/1399 #1400

wants to merge 2 commits into from

Conversation

btakita
Copy link
Contributor

@btakita btakita commented May 2, 2018

Store - Cyclical Dependency Detected when child computed property defined before parent & grand-parent computed proprety

Store - Cyclical Dependency Detected when child computed property defined before parent & grand-parent computed proprety
@codecov-io
Copy link

codecov-io commented May 2, 2018

Codecov Report

Merging #1400 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1400   +/-   ##
=======================================
  Coverage   91.25%   91.25%           
=======================================
  Files         122      122           
  Lines        4485     4485           
  Branches     1385     1385           
=======================================
  Hits         4093     4093           
  Misses        154      154           
  Partials      238      238

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ec21f7...058e1bd. Read the comment docs.

@btakita btakita changed the title Fix https://github.com/sveltejs/svelte/issues/1399 Fix issues/1399 May 2, 2018
@Rich-Harris
Copy link
Member

Thanks @btakita. I'm not 100% sure the rootKey mechanism is correct — the error I get for the case where a and b depend on each other doesn't mention b, as key and rootKey are both a. I think it might need to be something more like #1405?

@btakita
Copy link
Contributor Author

btakita commented May 2, 2018

Sounds good to me :-)

@btakita btakita closed this May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants