Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent binding to imports #13035

Merged
merged 3 commits into from
Aug 27, 2024
Merged

fix: prevent binding to imports #13035

merged 3 commits into from
Aug 27, 2024

Conversation

Rich-Harris
Copy link
Member

Alternative to #13033, fixes #13027 — prevents binding to imports, just like we already prevent binding to other constants (including derived values).

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Aug 26, 2024

🦋 Changeset detected

Latest commit: fd78a91

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dummdidumm
Copy link
Member

Makes sense (Svelte 4 errors, too), but template is not a valid value yet (at least from the types)?

@Rich-Harris
Copy link
Member Author

yeah i put it in the generated file, d'oh. fixing

@dummdidumm dummdidumm merged commit 8cda791 into main Aug 27, 2024
9 checks passed
@dummdidumm dummdidumm deleted the gh-13033 branch August 27, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte 5 RollupError: Illegal reassignment of import
2 participants