Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't reassign bound imports on the server #13033

Closed
wants to merge 1 commit into from

Conversation

dummdidumm
Copy link
Member

fixes #13027

WIP, needs a test

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Aug 26, 2024

🦋 Changeset detected

Latest commit: e965e57

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member

We already treat binding to constants as an error, we should just do the same for imports so that we get a nice compile time error. Opened #13035.

If we wanted to allow binding to imports so that components (and only components, not elements) can mutate properties of a constant, then we could do that, but we should do it for all constants and not just imports.

If we omit the setter, as here, it would mean getting an error like this (depending on browser)...

Uncaught TypeError: Cannot set property blah of #<Object> which has only a getter

...which is decipherable if you know what's going on, but not totally descriptive. (The error also only happens in strict mode, though I suspect that covers everyone that uses Svelte since we're living in an ESM world.) We could provide a better error in dev, if we were to go down that road. I'm not sure it's all that necessary though.

@dummdidumm
Copy link
Member Author

Closing in favor of #13035.

@dummdidumm dummdidumm closed this Aug 26, 2024
@dummdidumm dummdidumm deleted the reassign-imports branch August 26, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte 5 RollupError: Illegal reassignment of import
2 participants