-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(kit): correct engines
constraint
#1696
Conversation
Maintain fix from #1470, but loosen other constraints which had no business being there.
🦋 Changeset detectedLatest commit: ec9b87e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Hmm. I'm not sure about this. The motivation for that version number came from: #1000 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's not really a reason anyone should be using Node 15 and I do think people have hit some issues with certain versions of it, but I guess I don't have an objection to this either
15 is irrelevant, shouldn't be used but will still work. This was mostly about lowering to the true values |
I believe It looks like the net result of this PR is just to allow |
hmm, does this mean vite-plugin-svelte should also revise its constraints? given 15 is about to be EOL and 14.13.1 is a patch level i don't really see the value behind this and think the previous constraint was ok. if 15 is allowed, should it be included in tests? |
I don't think we should test against 15. I'm maybe okay saying we shouldn't prevent people from using it, but it definitely shouldn't be supported in any way |
Maintain fix from #1470, but loosen other constraints which had no business being there.