Create-Svelte - Fixing sucrase issue while running build script

[rafaelcamaram]

I was trying to run the create-svelte CLI locally but I was not able to do it with success. I realized that we got the #989 merged and, with this, we were not able to run npm run build in order to build the dist folder (and then run the CLI to set a project).

import { transform } from 'sucrase';
         ^^^^^^^^^
SyntaxError: The requested module 'sucrase' is expected to be of type CommonJS, which does not support named exports. CommonJS modules can be imported by importing the default export.
For example:
import pkg from 'sucrase';
const { transform } = pkg;

Tests

• Run the tests with pnpm test and lint the project with pnpm lint

[benmccann]

PR 1000!! Congrats! 😄

[Rich-Harris]

thanks — can you fix the lint errors please? (note that i just pushed a commit to this branch — we use uppercase sparingly in these parts :)

FYI the reason this failed locally for you is probably that you're on an ancient version of Node. Since 12.20 or something like that, named imports from CommonJS modules are possible in the majority of cases

[Conduitry]

I don't think there's anything that actually needs fixing here. If there was flakiness in some part of the automated build/publish, we should just try to run that again.

Locally, on latest master, I'm able to run pnpm -r build without error, and I'm able to manually run bin.js to create a new starter app from the template, and when I run npm pack in create-svelte to double-check which files would be getting published to npm, it contains precisely the files I would expect.

What's being changed in this PR does seem to just be something that's already supported in later versions of Node.

[Conduitry]

I've opened #1001 to hopefully resolve the problem that was preventing the automatic publishes from happening.

[benmccann]

Working version is published now. Thanks for pointing out the issue

[delhanty]

thanks — can you fix the lint errors please? (note that i just pushed a commit to this branch — we use uppercase sparingly in these parts :)

FYI the reason this failed locally for you is probably that you're on an ancient version of Node. Since 12.20 or something like that, named imports from CommonJS modules are possible in the majority of cases

Just a note for anybody else that follows me (also tag future self "mentioned" @delhanty): make sure you have at least the latest version of Node 14 installed.

I ran into this import { transform } from 'sucrase' problem with Node 14.6 and it went away when I upgraded to Node 14.17.

Edit: looks like the minimum versions are v12.20 and v14.13.1. I will make a pull request to document this in the README.

@dandv @dfabulich @kathy-ems Node.js 14.13.0 added support for named CJS exports, see #35249 and this change has also been backported to Node.js v12.20.0.

nodejs/node#32137 (comment)