pnpm?

[wmertens]

I just stumbled on https://pnpm.js.org/ - it uses a nice mix of symlinks and hardlinks to install deps, and seems to work properly for most packages.

It actually seems already quite a long way towards nix - the modules are stored separately in a cache and then combined in the project.

Maybe some ideas from there can be used here, or we can add the option to use the nix store in there.

They are using hardlinks to copy the modules in place, so to keep the original modules in the store they should either be mentioned in some file, or the hardlinks should be symlinks.

[adisbladis]

A while back I started a separate project for this: https://github.com/adisbladis/pnpm2nix/

[svanderburg]

Perhaps with hard linking we could save some of the duplication penalties, but I think this is already addressed by Nix -- Nix has an optimization feature as well that replaces duplicate files by hard links (e.g. nix-store --optimise). It just needs to be invoked explicitly, or it can be enabled for each package that gets deployed by adjusting the nix.conf configuration file.

I'm not sure what other concepts I could borrow -- the purpose of node2nix is not to alter or improve upon NPM, only to make integration work as conveniently as possible while retaining compatibility.

btw pnpm2nix is a nice effort!

[onetom]

pnpm was actually working until recently, like:

nix-shell -p nodePackages_8_x.pnpm

so I think this issue can be closed.

It currently fails, but that might be unrelated to node2nix.
If it's related, it should be a separate issue.

./pnpm/lib/node_modules/buffer/bin/download-node-tests.js: interpreter directive changed from "/usr/bin/env node" to "/nix/store/2wm0059s37nmyqb0qxlsdmcj0d4hlf2a-nodejs-8.12.0/bin/node"
./pnpm/lib/node_modules/tree-kill/cli.js: interpreter directive changed from "/usr/bin/env node" to "/nix/store/2wm0059s37nmyqb0qxlsdmcj0d4hlf2a-nodejs-8.12.0/bin/node"
No package-lock.json file found, reconstructing...
npm ERR! code EUNSUPPORTEDPROTOCOL
npm ERR! Unsupported URL Type "link:": link:../../privatePackages/assert-project

npm ERR! A complete log of this run can be found in:
npm ERR!     /private/var/folders/sp/dp9j0mxs3b3c_3g6sfs_7qwm0000gn/T/nix-build-node-pnpm-2.18.2.drv-0/.npm/_logs/2018-11-26T05_47_44_227Z-debug.log
builder for '/nix/store/9bbcavn00awfrdcfp5ahh0a48y3ybidj-node-pnpm-2.18.2.drv' failed with exit code 1
error: build of '/nix/store/9bbcavn00awfrdcfp5ahh0a48y3ybidj-node-pnpm-2.18.2.drv' failed

[srghma]

issue mentioned at #79 (comment) is fixed

[svanderburg]

Closing this, because the corresponding pnpm issue was fixed.