Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pnpm: fix build error "unsupported URL Type link" #54633

Merged
merged 1 commit into from
Jan 26, 2019

Conversation

srghma
Copy link
Contributor

@srghma srghma commented Jan 26, 2019

Motivation for this change

fixes svanderburg/node2nix#79 (comment)

based on codaxy/cxjs#279 (comment) link: is same as file:

Before build was failed with error https://pastebin.com/69G0DgKu

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 26, 2019
@dywedir
Copy link
Member

dywedir commented Jan 26, 2019

@GrahamcOfBorg build nodePackages.pnpm

@dywedir
Copy link
Member

dywedir commented Jan 26, 2019

Thanks!

@dywedir dywedir merged commit d359b5d into NixOS:master Jan 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pnpm?
3 participants