fix: parse error when only outputs is changed #896
Conversation
pkg/terraform/parser.go
Outdated
| if startChangeOutput != -1 && endChangeOutput == -1 && strings.HasPrefix(line, "Plan: ") { // https://github.com/hashicorp/terraform/blob/dfc12a6a9e1cff323829026d51873c1b80200757/internal/command/views/plan.go#L306 | ||
| endChangeOutput = i + 1 | ||
| if startChangeOutput != -1 && endChangeOutput == -1 && strings.HasPrefix(line, "-----") { // https://github.com/hashicorp/terraform/blob/1ac7a37d00f3c796f816070847bf02109cb9cab2/internal/command/views/operation.go#L142 |
There was a problem hiding this comment.
To include changes to outputs coming after Plan:, we have to wait for a horizontal rule which comes after Changes to Outputs:.
| // if we get here before finding a horizontal rule, output all remaining. | ||
| if endChangeOutput == -1 { | ||
| endChangeOutput = len(lines) - 1 | ||
| } |
There was a problem hiding this comment.
If TF_IN_AUTOMATION environment variable is set, no horizontal rules appear after Terraform will perform the following actions:. 😢
| name: "plan output changes only pattern 0.12", | ||
| body: planOnlyOutputChangesSuccessResult0_12, | ||
| result: ParseResult{ | ||
| Result: "Plan: 0 to add, 0 to change, 0 to destroy.", |
There was a problem hiding this comment.
This is not ideal, but it's very old version... 🙈
|
Thank you for your contribution! |
|
I'm reviewing this pr yet, but I found an issue. $ terraform version
Terraform v1.5.7
on darwin_arm64
+ provider registry.terraform.io/hashicorp/github v5.35.0main.tf import {
id = "tfaction"
to = github_repository.tfaction
}
output "foo" {
value = "foo"
}$ tfcmt plan -- terraform plan
Changes to Outputs:
+ foo = "foo"
You can apply this plan to save these new output values to the Terraform
state, without changing any real infrastructure.
╷
│ Error: Import block target does not exist
│
│ on main.tf line 1:
│ 1: import {
│
│ The target for the given import block does not exist. If you wish to
│ automatically generate config for this resource, use the
│ -generate-config-out option within terraform plan. Otherwise, make sure the
│ target resource exists within your configuration. For example:
│
│ terraform plan -generate-config-out=generated.tf
╵tfcmt v4.5.0 
This pull Request 
At least, the output |
|
Thanks for testing. 😃 |
|
OK, I tested. failed, resource changing, outputs changingBoth v4.5.0 and this PR version have the same result. failed, resource changing, outputs no changesSame as failed, resource no changes, outputs changingv4.5.0this PR versionno error, resource changing, outputs changingv4.5.0this PR versionno error, resource changing, outputs no changesBoth v4.5.0 and this PR version have the same result. no error, resource no changes, outputs changingv4.5.0this PR version |
|
Fixed the problem I noticed in images in the comment above. 🎉 Problem: beforeafterProblem: I copied the test cases from mercari/tfnotify#109, but it may be that Terraform's output specification changed at some point. beforeafter |
|
Thank you for your update. 
I'd like to make this message easier to understand. For example, how about Plan ResultPlan ResultWhat do you think? If you come up with better messages, please let me know. |
|
That's what I thought too, but pretended not to see. 🙈 Since it is plan, how about changing it to |
Oh, I see. Indeed, Terraform uses e.g.
Could you change to
|
|
Other than that it looks good. |
|
fixed: 6fa879f I'm not too sure about this fix. 😅 |
|
Thank you for your great work! |
|
The prerelease version v4.5.1-1 is out. We'll verify this, and if there is no problem, we'll release v4.5.1. |
|
v4.5.1 is out 🎉 Thank you for your contribution! |
Close #117
Related PR: mercari/tfnotify#109