Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Terraform >= 0.15 or later plan output only changes #109

Conversation

KeisukeYamashita
Copy link
Contributor

WHY

For #108
The tfnotify runs into error where there are only changes on the outputs.

Signed-off-by: KeisukeYamashita <[email protected]>
Signed-off-by: KeisukeYamashita <[email protected]>
@KeisukeYamashita KeisukeYamashita self-assigned this Feb 1, 2022
@KeisukeYamashita KeisukeYamashita changed the title Support Terraform >= 0.15 or later output only changes Support Terraform >= 0.15 or later plan output only changes Feb 1, 2022
Comment on lines +113 to +118
Terraform will perform the following actions:

Plan: 0 to add, 0 to change, 0 to destroy.

Changes to Outputs:
+ aws_instance_name = "my-instance"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've never seen terraform <0.15 output this. Is this some flag that is passed with terraform plan that makes it output this? I've only seen the "no changes" string.

Copy link
Contributor Author

@KeisukeYamashita KeisukeYamashita Feb 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@drlau Thank you for your review, can you check this issue, please? #108

I can reproduce with v0.14.10 🙏

@KeisukeYamashita KeisukeYamashita merged commit 3fee50b into mercari:master Feb 1, 2022
@KeisukeYamashita KeisukeYamashita deleted the support-terraform-0-15-or-later-output-only-changes branch February 1, 2022 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants