feat: enable must-gather for uwm #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sthaha
reviewed
Nov 7, 2023
must-gather/gather-monitoring-info
Outdated
|
|
||
| get_rules() { | ||
| log "getting prometheus rules" | ||
| THANOS_RULER_ROUTE="$(oc get routes -n $UWM_NS thanos-ruler -o jsonpath='{.status.ingress[0].host}')" |
There was a problem hiding this comment.
As a general rule of thumb, all initialisations that is more complex than an variable assignment, is better placed in to an init function. Use UPPER_CASE for globals and snake_case for local (use local).
vprashar2929
force-pushed
the
mon-gather
branch
2 times, most recently
from
af36248 to
f6267ba
Compare
sthaha
reviewed
Nov 9, 2023
must-gather/gather-monitoring-info
Outdated
|
|
||
| THANOS_RULER_ROUTE="$(oc get routes -n $UWM_NS thanos-ruler -o jsonpath='{.status.ingress[0].host}')" | ||
| SA_TOKEN="$(oc create token default)" | ||
| PROM_PODS="$(oc -n $UWM_NS get pods -l app.kubernetes.io/component=prometheus -oname 2>/dev/null || echo "")" |
There was a problem hiding this comment.
Suggested change
| PROM_PODS="$(oc -n $UWM_NS get pods -l app.kubernetes.io/component=prometheus -oname 2>/dev/null || echo "")" | |
| PROM_PODS="$(oc -n $UWM_NS get pods -l app.kubernetes.io/component=prometheus -oname)" || true | |
| declare -r PROM_PODS THANOS_RULER_ROUTE SA_TOKEN |
sthaha
reviewed
Nov 9, 2023
| PROM_PODS="$(oc -n $UWM_NS get pods -l app.kubernetes.io/component=prometheus -oname 2>/dev/null || echo "")" | ||
| } | ||
|
|
||
| cleanup() { |
There was a problem hiding this comment.
how about trap cleanup EXIT ?
sthaha
reviewed
Nov 9, 2023
|
|
||
| main() { | ||
| init | ||
|
|
There was a problem hiding this comment.
we should return 0 if PROM_PODS is empty
how about init || { warn "cannot gather UWM details"; return 0; }
init can return 0 or 1 depending on the vars could be initialised or not - right?
sthaha
previously approved these changes
Nov 9, 2023
Signed-off-by: Vibhu Prashar <[email protected]>
vprashar2929
force-pushed
the
mon-gather
branch
from
f6267ba to
6902902
Compare
sthaha
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for capturing
User-Workload-Monitoringrelated info in must-gather