Mono modes in MPE #756
Merged
Mono modes in MPE #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The releases in MPE mode didn't correctly map to the MPE Channel so ended up sticking. This fixes those problems by chosing the right off-channel voice for legato adjustment or next-activation in the mono modes. Closes surge-synthesizer#339 Closes surge-synthesizer#742
baconpaul
added a commit
to baconpaul/surge
that referenced
this pull request
Jul 10, 2019
The releases in MPE mode didn't correctly map to the MPE Channel so ended up sticking. This fixes those problems by chosing the right off-channel voice for legato adjustment or next-activation in the mono modes. Closes surge-synthesizer#339 Closes surge-synthesizer#742 Former-commit-id: 0c103487029a9a9b2ff8088d57495508af49f8d4 [formerly 107dca6] Former-commit-id: 5acff8033437d69d9d54d01beabaf0310e85042d Former-commit-id: 1f78d94eb942d82c6ff5fd658bb077dbbbb8661b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The releases in MPE mode didn't correctly map to the MPE Channel
so ended up sticking. This fixes those problems by chosing the
right off-channel voice for legato adjustment or next-activation
in the mono modes.
Closes #339
Closes #742