Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPE Stuck notes in mono ST + FP if playing legato #742

Closed
fredericcormier opened this issue Mar 7, 2019 · 6 comments · Fixed by #756
Closed

MPE Stuck notes in mono ST + FP if playing legato #742

fredericcormier opened this issue Mar 7, 2019 · 6 comments · Fixed by #756
Milestone

Comments

@fredericcormier
Copy link

Stuck notes when using mono ST + FT when MPE is enabled
Only if playing legato.
No stuck notes when playing staccato

See attached Logic X Project.

Note. I couldn't use a midi file because when importing that midi file, the daw creates as many tracks as channels that my controller uses ( 8 in the case of the Linnstrument ).
Joining/Merging this tracks produces a track that plays differently than the original
MPE-Mono-test.zip

Linnstrument 128
OSX 10.12.6
Logic 10.4.4
Nightly build 2019-03-06

@baconpaul
Copy link
Collaborator

Thank you! Very useful. I was also able to stick it last night in logic and have been staring at the voice stealing code ... with our examples I will be able to fix this no problem before beta 7!

@baconpaul
Copy link
Collaborator

baconpaul commented Mar 7, 2019

Oh and @fredericcormier I'm thinking we should have some MPE patches included in the synth factory patches. I have one or two going but if you end up coming up with any you want to contribute that work well for you, we would be happy to include them. I'll make a separate issue if you are interested. (cc: @esaruoho)

@fredericcormier
Copy link
Author

fredericcormier commented Mar 7, 2019 via email

@baconpaul baconpaul added the mpe label Mar 7, 2019
@baconpaul baconpaul added this to the 1.6.0 milestone Mar 7, 2019
baconpaul added a commit to baconpaul/surge that referenced this issue Mar 8, 2019
The releases in MPE mode didn't correctly map to the MPE Channel
so ended up sticking. This fixes those problems.

ToDo: Check poly mode carefully, test a lot.

Closes surge-synthesizer#339
Closes surge-synthesizer#742
@baconpaul
Copy link
Collaborator

Just an FYI: Your excellent example allowed me to find a fix to this this morning. I need to test it extensively still (which I will do today) but I think we can get this problem resolved in a nightly this weekend and in beta 7 for sure. Thank you very much.

@fredericcormier
Copy link
Author

fredericcormier commented Mar 8, 2019 via email

baconpaul added a commit to baconpaul/surge that referenced this issue Mar 9, 2019
Correct sense name per his request; add @tavasti as an author
per his sweep.

Mono modes in MPE

The releases in MPE mode didn't correctly map to the MPE Channel
so ended up sticking. This fixes those problems.

ToDo: Check poly mode carefully, test a lot.

Closes surge-synthesizer#339
Closes surge-synthesizer#742

Regular and FP poly mode works; ST doesn't stick
baconpaul added a commit to baconpaul/surge that referenced this issue Mar 9, 2019
The releases in MPE mode didn't correctly map to the MPE Channel
so ended up sticking. This fixes those problems. It leaves one
lignering problem: in mono_st modes the pitchbend does not
get delivered to the playing voice correctly when doing
2 note or more held.

Closes surge-synthesizer#339
Closes surge-synthesizer#742
baconpaul added a commit to baconpaul/surge that referenced this issue Mar 9, 2019
The releases in MPE mode didn't correctly map to the MPE Channel
so ended up sticking. This fixes those problems by chosing the
right off-channel voice for legato adjustment or next-activation
in the mono modes.

Closes surge-synthesizer#339
Closes surge-synthesizer#742
@baconpaul
Copy link
Collaborator

@fredericcormier I have fixed this tonight. Boy it was a bit fiddly....

It will take about an hour for the new nightly to show up on the website I think, but if you have some time this weekend, grabbing a nightly from later tonight and really stress testing some of the MPE mono mode would be great. I stressed it with both my roli and in non mpe mode with my keyboard but the more the better.

baconpaul added a commit that referenced this issue Mar 9, 2019
The releases in MPE mode didn't correctly map to the MPE Channel
so ended up sticking. This fixes those problems by chosing the
right off-channel voice for legato adjustment or next-activation
in the mono modes.

Closes #339
Closes #742
baconpaul added a commit to baconpaul/surge that referenced this issue Jul 10, 2019
The releases in MPE mode didn't correctly map to the MPE Channel
so ended up sticking. This fixes those problems by chosing the
right off-channel voice for legato adjustment or next-activation
in the mono modes.

Closes surge-synthesizer#339
Closes surge-synthesizer#742

Former-commit-id: 0c103487029a9a9b2ff8088d57495508af49f8d4 [formerly 107dca6]
Former-commit-id: 5acff8033437d69d9d54d01beabaf0310e85042d
Former-commit-id: 1f78d94eb942d82c6ff5fd658bb077dbbbb8661b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants