Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deactivate misleading tuning typeins in Tune-After mode #7178

Merged
merged 3 commits into from
Aug 12, 2023

Conversation

baconpaul
Copy link
Collaborator

In Tune-After mode the typein "9/8" didn't uniformly give you a 9/8 pitch shift; it gave you that many keys shift. This was rather confusing. Some even called it "borked". So just make a clear error that this typein style is only availabel in tune-at-midi mode

Closes #6977

In Tune-After mode the typein "9/8" didn't uniformly give you
a 9/8 pitch shift; it gave you that many keys shift. This was
rather confusing. Some even called it "borked". So just make
a clear error that this typein style is only availabel in
tune-at-midi mode

Closes surge-synthesizer#6977
src/common/Parameter.cpp Outdated Show resolved Hide resolved
@Andreya-Autumn
Copy link
Collaborator

"No ratio typeins in tune-after mode"

@baconpaul baconpaul merged commit 41942bf into surge-synthesizer:main Aug 12, 2023
@baconpaul baconpaul deleted the no-frac-after-6977 branch August 12, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pitch type-ins are a tiny bit borked with "Apply tuning after modulation"
3 participants