Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pitch type-ins are a tiny bit borked with "Apply tuning after modulation" #6977

Closed
Andreya-Autumn opened this issue Apr 22, 2023 · 3 comments · Fixed by #7178
Closed

Pitch type-ins are a tiny bit borked with "Apply tuning after modulation" #6977

Andreya-Autumn opened this issue Apr 22, 2023 · 3 comments · Fixed by #7178
Labels
Discussion Tuning Non-standard tuning extensions UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Milestone

Comments

@Andreya-Autumn
Copy link
Collaborator

So... you have loaded a tuning with a 3/2 in it, and checked the mentioned option. You type-in "3/2" in the pitch field of an oscillator, it won't play 3/2.

That's because with apply after modulation checked, putting pitch to 7.00 exactly is remapped to 7 keys up, and typing in 3/2 doesn't land you on 7 steps it lands you on ≈7.02.

So you probably expected to land on 3/2 since that's what you typed in, and that interval is in your scale. But instead you landed a bit sharp of the 7th degree in your scale. How sharp depends on what the 8th degree is, since this mode interpolates the pitches between the integer degrees.

There are two options for solving this. Either we just document it as it is, basically saying "in this mode, always type in pitch offsets as 100 cent intervals.

...or make it so whenever the user types in a ratio that's present in the scale, make sure the param ends in the place that actually makes that sound.

The latter would be more intuitive in some cases. But of course, it'd still only be when playing the root of the scale that you'd actually be guaranteed to hear the interval you typed in.

@Andreya-Autumn Andreya-Autumn added Tuning Non-standard tuning extensions Discussion labels Apr 22, 2023
@mkruselj mkruselj added this to the Surge XT 1.3 milestone Apr 23, 2023
@mkruselj mkruselj added the UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc. label Apr 23, 2023
@baconpaul
Copy link
Collaborator

I think the best bet here is, in after modulation mode, if you type in a fraction or tuning value it actually returns a clear error saying "tones not supported in after mode" or some such.

thoughts?

@mkruselj
Copy link
Collaborator

mkruselj commented Aug 9, 2023

I agree with that, Occam's razor.

@Andreya-Autumn
Copy link
Collaborator Author

For 1.3 sure! For XT2 it'd be nice to solve it differently but that's already noted in #6983

baconpaul added a commit to baconpaul/surge that referenced this issue Aug 12, 2023
In Tune-After mode the typein "9/8" didn't uniformly give you
a 9/8 pitch shift; it gave you that many keys shift. This was
rather confusing. Some even called it "borked". So just make
a clear error that this typein style is only availabel in
tune-at-midi mode

Closes surge-synthesizer#6977
baconpaul added a commit that referenced this issue Aug 12, 2023
In Tune-After mode the typein "9/8" didn't uniformly give you
a 9/8 pitch shift; it gave you that many keys shift. This was
rather confusing. Some even called it "borked". So just make
a clear error that this typein style is only availabel in
tune-at-midi mode

Closes #6977
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion Tuning Non-standard tuning extensions UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants