Remediate a few more C-style strings #7064
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baconpaul
reviewed
Jun 22, 2023
src/common/PatchDB.cpp
Outdated
| snprintf(msg, 1024, "SQL Error[%d]: %s", rc, std::runtime_error::what()); | ||
| return msg; | ||
| static std::string msg = | ||
| fmt::format("SQL Error[{:d}]: {:s}", rc, std::runtime_error::what()); |
There was a problem hiding this comment.
Oh no this is very wrong! Pls don’t merge
There was a problem hiding this comment.
The old one is also super wierd. I need to peek
|
Ok the parch db one is you correctly porting my insane code. Can you back it out and I will do the right fix? thrn unit tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #6730