Review and ideally remediate old style C string handling #6730
Labels
Code Refactoring
General code refactoring and cleanup issues like names, unused variables, warnings, fixme
Milestone
We have
std::string
and we havefmt::format
There's a few places where we have to use
char *
but nowhere near as many as we do.snprintf
sprintf
strncpy
My comment from discord, edited.
The constraint is: Parameter needs to be copyable with memcpy so it can't have complex types like std::string as data members
But other than that everything can be std::string and it can easily have complex types as interface points
So, like
could easily change to
and then mark old get_display as deprecated, make it call get_display string version and do a strncpy
But these members in parameter
And as to that override I meant
until you remove all get_displays etc....
The text was updated successfully, but these errors were encountered: