Fix a problem in FX about param position assumption #7053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The FX unit assumed &FxStorage == &FxStorage->type in one spot, which it had since epoch, but with the addition of a member at the top of the class, that assumption broke, and blammeroonie. So do three things 1. Fix that assumption in SurgeFXProcessor 2. Move the new member to the end of the class just in case. Like we need to clean up the rack client which may do the same. And 3. Add a big honkin comment explaning this Closes surge-synthesizer#7052
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FX unit assumed &FxStorage == &FxStorage->type in one spot, which it had since epoch, but with the addition of a member at the top of the class, that assumption broke, and blammeroonie.
So do three things
Closes #7052