Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FX plugin borked #7052

Closed
mkruselj opened this issue Jun 19, 2023 · 0 comments · Fixed by #7053
Closed

FX plugin borked #7052

mkruselj opened this issue Jun 19, 2023 · 0 comments · Fixed by #7053
Labels
Bug Report Item submitted using the Bug Report template DSP Issues and feature requests related to sound generation in the synth FX Plugin Issues pertaining to Surge XT Effects plugin
Milestone
Surge XT 1.3

Comments

@mkruselj
Copy link
Collaborator

Bug Description:
UI opens but FX don't FX properly. Some sound weird/broken, most don't sound at all. Changing FX from the menu updates the UI but modifying any parameters doesn't do anything.

Surge XT Version
Started happening at commit 94e5773 (audio in effect)
@mkruselj mkruselj added DSP Issues and feature requests related to sound generation in the synth Bug Report Item submitted using the Bug Report template FX Plugin Issues pertaining to Surge XT Effects plugin labels Jun 19, 2023
@mkruselj mkruselj added this to the Surge XT 1.3 milestone Jun 19, 2023
baconpaul added a commit to baconpaul/surge that referenced this issue Jun 19, 2023
@baconpaul
Fix a problem in FX about param position assumption
5db44fb 
The FX unit assumed &FxStorage == &FxStorage->type in one
spot, which it had since epoch, but with the addition of
a member at the top of the class, that assumption broke, and
blammeroonie.

So do three things

1. Fix that assumption in SurgeFXProcessor
2. Move the new member to the end of the class just in case.
   Like we need to clean up the rack client which may do the same.
   And
3. Add a big honkin comment explaning this

Closes surge-synthesizer#7052
@baconpaul baconpaul mentioned this issue Jun 19, 2023
Merged
baconpaul added a commit that referenced this issue Jun 19, 2023
@baconpaul
Fix a problem in FX about param position assumption (#7053)
dad169b 
The FX unit assumed &FxStorage == &FxStorage->type in one
spot, which it had since epoch, but with the addition of
a member at the top of the class, that assumption broke, and
blammeroonie.

So do three things

1. Fix that assumption in SurgeFXProcessor
2. Move the new member to the end of the class just in case.
   Like we need to clean up the rack client which may do the same.
   And
3. Add a big honkin comment explaning this

Closes #7052
This was referenced Mar 5, 2024
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Report Item submitted using the Bug Report template DSP Issues and feature requests related to sound generation in the synth FX Plugin Issues pertaining to Surge XT Effects plugin
Projects
None yet
Milestone
Surge XT 1.3
Development

Successfully merging a pull request may close this issue.

Fix a problem in FX about param position assumption baconpaul/surge
1 participant
@mkruselj