frame->close in ~SurgeGUIEditor #669
Merged
+1
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Call frame->close which does a removeAll and a forget, like we used to, but also does a bunch of other internal implementations. Reported by @sagantech. Reading the vstgui code for close this is obviously correct. Closes surge-synthesizer#503 call close
|
I tested this by repeatedly opening and closing the app in host and flavor combinations on all platforms in my vm as well as reading the cframe::close implementation. Gonna sweep this one once the auto builds work. |
baconpaul
added a commit
to baconpaul/surge
that referenced
this pull request
Jul 10, 2019
Call frame->close which does a removeAll and a forget, like we used to, but also does a bunch of other internal implementations. Reported by @sagantech. Reading the vstgui code for close this is obviously correct. Closes surge-synthesizer#503 call close Former-commit-id: 4f02a9e91e8ad19c21d2fbcf7cb087b863f4cdae [formerly 1f386b6] Former-commit-id: 00477939f7c6dcdf6b3d3c25d69519c82d64db61 Former-commit-id: 49e685ef380444f109653fa771e6689a025767c1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call frame->close which does a removeAll and a forget, like we
used to, but also does a bunch of other internal implementations.
Reported by @sagantech. Reading the vstgui code for close this
is obviously correct.
Closes #503 call close