Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SurgeGUIEditor::~SurgeGUIEditor() should call frame->close #503

Closed
sagantech opened this issue Feb 4, 2019 · 1 comment · Fixed by #669
Closed

SurgeGUIEditor::~SurgeGUIEditor() should call frame->close #503

sagantech opened this issue Feb 4, 2019 · 1 comment · Fixed by #669
Milestone
1.6.0

Comments

@sagantech
Copy link
Contributor

Right now it calls removeall and forget(). I believe this is incorrect as it misses implementation specific stuff and other cleanup.
@baconpaul baconpaul added this to the 1.6.0 milestone Feb 24, 2019
@baconpaul
Copy link
Collaborator

Just turning to this now sorry. Yeah reading the vstgui code you are correct indeed. I'll test it and put the change into the next beta.

baconpaul added a commit to baconpaul/surge that referenced this issue Feb 26, 2019
@baconpaul
frame->close in ~SurgeGUIEditor
4246136 
Call frame->close which does a removeAll and a forget, like we
used to, but also does a bunch of other internal implementations.
Reported by @sagantech. Reading the vstgui code for close this
is obviously correct.

Closes surge-synthesizer#503 call close
@baconpaul baconpaul mentioned this issue Feb 26, 2019
Merged
baconpaul added a commit that referenced this issue Feb 26, 2019
@baconpaul
frame->close in ~SurgeGUIEditor (#669)
1f386b6 
Call frame->close which does a removeAll and a forget, like we
used to, but also does a bunch of other internal implementations.
Reported by @sagantech. Reading the vstgui code for close this
is obviously correct.

Closes #503 call close
baconpaul added a commit to baconpaul/surge that referenced this issue Jul 10, 2019
@baconpaul
frame->close in ~SurgeGUIEditor (surge-synthesizer#669)
1e7d736 
Call frame->close which does a removeAll and a forget, like we
used to, but also does a bunch of other internal implementations.
Reported by @sagantech. Reading the vstgui code for close this
is obviously correct.

Closes surge-synthesizer#503 call close

Former-commit-id: 4f02a9e91e8ad19c21d2fbcf7cb087b863f4cdae [formerly 1f386b6]
Former-commit-id: 00477939f7c6dcdf6b3d3c25d69519c82d64db61
Former-commit-id: 49e685ef380444f109653fa771e6689a025767c1
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.6.0
Development

Successfully merging a pull request may close this issue.

frame->close in ~SurgeGUIEditor baconpaul/surge
2 participants
@baconpaul @sagantech