Correct AW Lifecycle; Restore AD-Clip #6548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fix in 91bc21c was not quite correct. The actual problem was that the the local ivalues were updated at the wrong point in the cycle for the re-start effect hence the 'phantom 0' in the pdata_ival but that phantom 0 is not in fxdata, which is correct, so adjust the code, preservbing the fix from the prior commit but also restoring the functionality of AD-Clip, aka AirWin ID 0 Closes surge-synthesizer#6479
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix in 91bc21c was not quite correct. The actual problem was
that the the local ivalues were updated at the wrong point in the cycle
for the re-start effect hence the 'phantom 0' in the pdata_ival
but that phantom 0 is not in fxdata, which is correct, so adjust the
code, preservbing the fix from the prior commit but also restoring
the functionality of AD-Clip, aka AirWin ID 0
Closes #6479