Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AD Clip #6479

Closed
baconpaul opened this issue Aug 5, 2022 · 5 comments · Fixed by #6548
Closed

AD Clip #6479

baconpaul opened this issue Aug 5, 2022 · 5 comments · Fixed by #6548
Labels
Airwindows Issues related to Airwindows effects implemented in Surge Bug Report Item submitted using the Bug Report template Effects FX Plugin Issues pertaining to Surge XT Effects plugin
Milestone
Surge XT 1.1.1

Comments

@baconpaul
Copy link
Collaborator

Reported by Chris S on KVR

BUG(?): Airwindows - AD Clip not working properly?

  1. The parameters (Boost, Soften, ..) do not have an effect.
  2. When switching to another Clipping-Preset (eg. Slew1) via the selector-box and back to AD Clip the parameter-set is not updated (stays on clamping).
@baconpaul baconpaul added the Bug Report Item submitted using the Bug Report template label Aug 5, 2022
@baconpaul baconpaul added this to the Surge XT 1.1.n milestone Aug 5, 2022
@baconpaul
Copy link
Collaborator Author

Confirmed both of these at head on macOS. No diagnosis yet.

@mkruselj mkruselj added Effects Airwindows Issues related to Airwindows effects implemented in Surge FX Plugin Issues pertaining to Surge XT Effects plugin labels Aug 6, 2022
@baconpaul
Copy link
Collaborator Author

Oh damnit
This is because ADClip has ID 0
and the change i made around the multi-drag re-initialization thought ID 0 was bypass

Hmm will be tricky to fix.

@baconpaul
Copy link
Collaborator Author

So this was caused by 91bc21c

@mkruselj
Copy link
Collaborator

Can we not change the ID of AD Clip then handle streaming etc?

@baconpaul
Copy link
Collaborator Author

yeah that's my thinking indeed. but that's a bit tricky to fix :)

baconpaul added a commit to baconpaul/surge that referenced this issue Aug 20, 2022
@baconpaul
Correct AW Lifecycle; Restore AD-Clip
d28506e 
The fix in 91bc21c was not quite correct. The actual problem was
that the the local ivalues were updated at the wrong point in the cycle
for the re-start effect hence the 'phantom 0' in the pdata_ival
but that phantom 0 is not in fxdata, which is correct, so adjust the
code, preservbing the fix from the prior commit but also restoring
the functionality of AD-Clip, aka AirWin ID 0

Closes surge-synthesizer#6479
@baconpaul baconpaul mentioned this issue Aug 20, 2022
Merged
baconpaul added a commit that referenced this issue Aug 20, 2022
@baconpaul
Correct AW Lifecycle; Restore AD-Clip (#6548)
25d39a0 
The fix in 91bc21c was not quite correct. The actual problem was
that the the local ivalues were updated at the wrong point in the cycle
for the re-start effect hence the 'phantom 0' in the pdata_ival
but that phantom 0 is not in fxdata, which is correct, so adjust the
code, preservbing the fix from the prior commit but also restoring
the functionality of AD-Clip, aka AirWin ID 0

Closes #6479
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Airwindows Issues related to Airwindows effects implemented in Surge Bug Report Item submitted using the Bug Report template Effects FX Plugin Issues pertaining to Surge XT Effects plugin
Projects
None yet
Milestone
Surge XT 1.1.1
Development

Successfully merging a pull request may close this issue.

Correct AW Lifecycle; Restore AD-Clip baconpaul/surge
2 participants
@mkruselj @baconpaul