Last lato 622 #644
Merged
Last lato 622 #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Runtime Fonts introduced Lato and runtime font resolution. CLFOGUI still had a hard coded reference to a font. Make that font a runtime resolved global at the SurgeGUI scope and resolve it to lato on mac/win and sans-serif on linux. Partially closes surge-synthesizer#622
In a review of surge-synthesizer#580 @jsakkine pointed out that the font global names were not clear as to their purpose and unlike everything else, prefixed with "surge_". This commit renames the 3 global fonts to more descriptive names.
|
On and will close #622 if we merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete the conversion to Lato font on Mac and Windows. Rename the font globals per @jsakkine review suggestion.
@jsakkine if you happen to get a chance to look I'd appreciate it, if only to make sure you like the names i picked!