Towards Font Overrides #6018
Merged
Towards Font Overrides #6018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The font stylesheets we started allowed us to speficy font objects but not to override them. This supports that in the skin, although it is still very incomplete. But to test it, I made modbutton fonts overridable using the new font syntax which we are working towards, which Closes surge-synthesizer#5843
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The font stylesheets we started allowed us to speficy font objects but not
to override them. This supports that in the skin, although it is still very
incomplete.
But to test it, I made modbutton fonts overridable using the new font
syntax which we are working towards, which Closes #5843