-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for changing modbutton font to custom font #5843
Comments
Yeah this all fits into the font style sheet consolidation. |
yeah we didn't get all the fonts for 10 but we can for 11. thanks @itsmedavep ! |
Per a discord convo Paul had asked me to add another issue to this one (if I understood him correctly!). FR: I would like to be able to change the stroke color on the macro slider box. Seems like these are the only options available (when I look at the skin guide nothing jumps out):
Unfortunately those dont hit the stroke around the slider box. |
Currently that stroke is using |
Addresses surge-synthesizer#5843 Also minor formatting tweaks, and slight renaming of waveshaper analysis font connectors (I bet nobody used them so far anyways).
Addresses #5843 Also minor formatting tweaks, and slight renaming of waveshaper analysis font connectors (I bet nobody used them so far anyways).
The font stylesheets we started allowed us to speficy font objects but not to override them. This supports that in the skin, although it is still very incomplete. But to test it, I made modbutton fonts overridable using the new font syntax which we are working towards, which Closes surge-synthesizer#5843
OK @itsmedavep we are working towards a global font list like we have a global color list. We aren't there yet but to test it, i made it work for the modbuttons Once I merge #6018 you can look at example 10 which will let you change mod button fonts If there are other fonts which need styling similarly, this is now actually 'very easy' (in fact we may sweep across everything for XT 1.1 and give proper font names now we can override at a skin level). Just lemme know where you get stuck if/when you return to this. |
The font stylesheets we started allowed us to speficy font objects but not to override them. This supports that in the skin, although it is still very incomplete. But to test it, I made modbutton fonts overridable using the new font syntax which we are working towards, which Closes #5843
You can change the font on sliders by utilizing font_family and then assigning a custom font.
I would like to be able to do that for the modbutton.
Right now it is here :
https://cdn.discordapp.com/attachments/758804883180355594/937123683409985566/Screen_Shot_2022-01-29_at_5.14.49_PM.png
https://cdn.discordapp.com/attachments/758804883180355594/937123683166728192/Screen_Shot_2022-01-29_at_5.14.22_PM.png
Also it might be relevant to consider the changes that will be taken over here:
#5027
And finally, perhaps it really boils down to wanting to be able to use a custom font everywhere fonts are used. AKA if I dont want to have Lato in the GUI I can not have Lato in the GUI.
Regardless, thank you for your consideration.
The text was updated successfully, but these errors were encountered: