Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for changing modbutton font to custom font #5843

Closed
itsmedavep opened this issue Jan 30, 2022 · 5 comments · Fixed by #6018
Closed

Support for changing modbutton font to custom font #5843

itsmedavep opened this issue Jan 30, 2022 · 5 comments · Fixed by #6018
Labels
Feature Request New feature request Skinning Engine Issues related to Surge's skin engine
Milestone

Comments

@itsmedavep
Copy link
Contributor

You can change the font on sliders by utilizing font_family and then assigning a custom font.

I would like to be able to do that for the modbutton.

Right now it is here :
https://cdn.discordapp.com/attachments/758804883180355594/937123683409985566/Screen_Shot_2022-01-29_at_5.14.49_PM.png
https://cdn.discordapp.com/attachments/758804883180355594/937123683166728192/Screen_Shot_2022-01-29_at_5.14.22_PM.png

Also it might be relevant to consider the changes that will be taken over here:
#5027

And finally, perhaps it really boils down to wanting to be able to use a custom font everywhere fonts are used. AKA if I dont want to have Lato in the GUI I can not have Lato in the GUI.

Regardless, thank you for your consideration.

@itsmedavep itsmedavep added the Feature Request New feature request label Jan 30, 2022
@mkruselj
Copy link
Collaborator

mkruselj commented Jan 30, 2022

Yeah this all fits into the font style sheet consolidation.

@mkruselj mkruselj added the Skinning Engine Issues related to Surge's skin engine label Jan 30, 2022
@mkruselj mkruselj modified the milestones: Surge 1.0.1, Surge XT 1.1 Jan 30, 2022
@baconpaul
Copy link
Collaborator

yeah we didn't get all the fonts for 10 but we can for 11. thanks @itsmedavep !

@mkruselj mkruselj changed the title FR: Support for changing modbutton font to custom font Support for changing modbutton font to custom font Jan 31, 2022
@mkruselj mkruselj closed this as completed Feb 2, 2022
@baconpaul baconpaul reopened this Feb 2, 2022
@itsmedavep
Copy link
Contributor Author

Per a discord convo Paul had asked me to add another issue to this one (if I understood him correctly!).

FR: I would like to be able to change the stroke color on the macro slider box.

Screen Shot 2022-02-03 at 7 01 00 PM

Seems like these are the only options available (when I look at the skin guide nothing jumps out):

<color id="modbutton.macro.slider.fill" value="blue"/> <color id="modbutton.macro.slider.background" value="base01"/> <color id="modbutton.macro.slider.currentvalue" value="orange"/>

Unfortunately those dont hit the stroke around the slider box.

@mkruselj
Copy link
Collaborator

mkruselj commented Feb 4, 2022

Currently that stroke is using modbutton.used.fill color. Not ideal, and yes a new color is certainly very easy to add!

mkruselj added a commit to mkruselj/surge that referenced this issue Mar 5, 2022
Addresses surge-synthesizer#5843

Also minor formatting tweaks, and slight renaming of waveshaper analysis font connectors (I bet nobody used them so far anyways).
mkruselj added a commit that referenced this issue Mar 5, 2022
Addresses #5843

Also minor formatting tweaks, and slight renaming of waveshaper analysis font connectors (I bet nobody used them so far anyways).
mkruselj added a commit to mkruselj/surge that referenced this issue Apr 3, 2022
mkruselj added a commit that referenced this issue Apr 3, 2022
baconpaul added a commit to baconpaul/surge that referenced this issue Apr 5, 2022
The font stylesheets we started allowed us to speficy font objects but not
to override them. This supports that in the skin, although it is still very
incomplete.

But to test it, I made modbutton fonts overridable using the new font
syntax which we are working towards, which Closes surge-synthesizer#5843
@baconpaul
Copy link
Collaborator

OK @itsmedavep we are working towards a global font list like we have a global color list. We aren't there yet but to test it, i made it work for the modbuttons

Once I merge #6018 you can look at example 10 which will let you change mod button fonts

If there are other fonts which need styling similarly, this is now actually 'very easy' (in fact we may sweep across everything for XT 1.1 and give proper font names now we can override at a skin level). Just lemme know where you get stuck if/when you return to this.

baconpaul added a commit that referenced this issue Apr 5, 2022
The font stylesheets we started allowed us to speficy font objects but not
to override them. This supports that in the skin, although it is still very
incomplete.

But to test it, I made modbutton fonts overridable using the new font
syntax which we are working towards, which Closes #5843
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request New feature request Skinning Engine Issues related to Surge's skin engine
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants