Ctrl+click on modbutton arms the unfocused LFO #5824
Conversation
|
Please clang-format the modified files, otherwise the PR cannot be merged. Also, please add yourself to AUTHORS file along with this PR. Thank you for contributing! |
|
Oh that currently selected skin color is a good idea. If you open a new issue for that I can add a quick hint or two |
|
And thanks! |
|
TBH I think we already have way too many colors for modbuttons (32!), so I would be cautious about slapping even more. Not a huge fan of the idea. It is already difficult to find colors that fit together in all these different states, without creating cognitive noise. There's no difference in the away LFO being armed vs currently selected LFO being armed. They're both armed. We have skin colors for "armed" state. That is sufficient IMO. |
|
And other than the clang format the change looks spot on! Happy to merge once authors and format changes are in. Thank you! |
mkruselj
changed the title
|
Yeah I couldn't think of a colour that would be distinct but not look funny, the arrow still shows what mod is selected so it's definitely not needed. I'm glad to help, merge at your leisure |
fix formatting, and fix some nitpicks remove white space revert one nitpick change
Implementing the workflow talked about here
#5818
It'd be cool if the currently selected lfo had a different colour on the matrix when in this mode but I'm not sure how that would be done.