Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modulating a modulator workflow improvement #5818

Closed
RaymondBaker opened this issue Jan 23, 2022 · 4 comments · Fixed by #5824
Closed

Modulating a modulator workflow improvement #5818

RaymondBaker opened this issue Jan 23, 2022 · 4 comments · Fixed by #5824
Labels
Feature Request New feature request Modulation Modulation related issues UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Milestone

Comments

@RaymondBaker
Copy link
Contributor

Is your feature request related to a problem? Please describe.
It'd be nice if the workflow to modulate the lfo 1 rate/deform/etc with lfo 2 was more intuitive. The arrow buttons are pretty confusing and the drag modulator feature doesn't bring up the modulation amt slider

Describe the solution you'd like:
If ctrl + click on a modulator could put it into an active state and no matter where you click on the mod section the original one is still active. (until ctrl clicked again) you could use that to modulate other modulators with ease

example workflow: ctrl click lfo 2 (maybe repurpose the arrow to do the same thing) then click lfo1 and modulate the rate with lfo 2 then click lfo3 and modulate some of its params with lfo 2. Ctrl click lfo 2 to get out of this mode

Describe alternatives you've considered:
I thought about having the drag and drop menu having a button to bring up the sliders but I think that's less intuitive than above.

P.S loving XT so far. If you want this feature I may be able to implement it if you can point me in the right direction :)

Additional context:
image
image

@RaymondBaker RaymondBaker added the Feature Request New feature request label Jan 23, 2022
@baconpaul
Copy link
Collaborator

so basically 'ctrl click on the 'away' modulator is the opposite of the orange arrow'?

Today: click LFO 2, arm it, orange arrow LFO 1 and you can drag LFO 1 rate to modulate from LFO 2 fine.
Today: Clcik LFO1, drag LFO2 onto rate and you get the typein. fine but you aren't armed.
(There's also the add moduation from option and the mod list approaches)

Suggested Addition: click LFO1, control-click LFO2, LFO2 arms and LFO1 stays active for target?

Or: Control-click on the non-selected modulator arms it without selecting it basically

Just making sure I get it.

I like that idea, but I know we have gestures already used so if that's right lets let @mkruselj weigh in also.

Your offer to implement it is kind. If I understood it and we decide to do it (with control or some other modifier) I will put some code hints here. Not super hard but not super easy alas. That code is kinda messy. But its testable.

@mkruselj
Copy link
Collaborator

mkruselj commented Jan 24, 2022

My thinking is that #5062 is a better solution for this problem.

We could still implement Ctrl/Cmd+click on modbutton arms the away modulator (meaning the down arrow never changes focus until you do normal click on modbutton or a direct click on it). Although, I am NOT a fan of making this a "lock" action. I would prefer Ctrl+clicking modbutton every time you need the down arrow to stay put - it is more of a deliberate decision this way and IMO prevents confusion.

Suggested Addition: click LFO1, control-click LFO2, LFO2 arms and LFO1 stays active for target?

Yep that's basically exactly what OP suggests.

@mkruselj mkruselj added Modulation Modulation related issues UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc. labels Jan 24, 2022
@RaymondBaker
Copy link
Contributor Author

Yep that's what I was suggesting

You're right it's probably better not to be a locking action, #5062 defiantly would fill this need. I'm thinking the ctrl click as more of an improvement on the arrow button workflow. At least for me I'd find it more clear if the arrow button/ctrl click armed the other modulator without changing the view. What do you guys think?

@mkruselj
Copy link
Collaborator

mkruselj commented Jan 25, 2022

Ctrl+click would definitely be much simpler to implement than #5062 (well, you already did it! 🙂). But #5062 would boost the whole modulation workflow and also make it similar to how it's done elsewhere, raising the familiarity factor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request New feature request Modulation Modulation related issues UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants