Handle bound components in menus #5402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was super careful to make sure my menus lived less long than the thises they bound, but in a close editor case I am out of luck. Tnanks to the TAP folks, especially daniel, I learned to use juce::Component::SafePointer<> which does what I need. See discussion in surge-synthesizer#5401 and the forum post linked there for more Closes surge-synthesizer#5401
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was super careful to make sure my menus lived less long than
the thises they bound, but in a close editor case I am out of
luck. Tnanks to the TAP folks, especially daniel, I learned
to use juce::Component::SafePointer<> which does what I need.
See discussion in #5401 and the forum post linked there for more
Closes #5401