Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing with a Menu open causes memory scribble #5401

Closed
baconpaul opened this issue Nov 14, 2021 · 1 comment · Fixed by #5402
Closed

Closing with a Menu open causes memory scribble #5401

baconpaul opened this issue Nov 14, 2021 · 1 comment · Fixed by #5402
Labels
Bug Report Item submitted using the Bug Report template
Milestone

Comments

@baconpaul
Copy link
Collaborator

https://forum.juce.com/t/async-menu-and-audioprocessoreditor-destruction-lifecycle/48777

See the description here.

@baconpaul baconpaul added the Bug Report Item submitted using the Bug Report template label Nov 14, 2021
@baconpaul baconpaul added this to the Surge XT 1.0 milestone Nov 14, 2021
@baconpaul
Copy link
Collaborator Author

The answer (thanks to daniel on tap) is to use juce::Component::SafePointer rather than this

baconpaul added a commit to baconpaul/surge that referenced this issue Nov 14, 2021
I was super careful to make sure my menus lived less long than
the thises they bound, but in a close editor case I am out of
luck. Tnanks to the TAP folks, especially daniel, I learned
to use juce::Component::SafePointer<> which does what I need.
See discussion in surge-synthesizer#5401 and the forum post linked there for more

Closes surge-synthesizer#5401
baconpaul added a commit that referenced this issue Nov 14, 2021
I was super careful to make sure my menus lived less long than
the thises they bound, but in a close editor case I am out of
luck. Tnanks to the TAP folks, especially daniel, I learned
to use juce::Component::SafePointer<> which does what I need.
See discussion in #5401 and the forum post linked there for more

Closes #5401
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Report Item submitted using the Bug Report template
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant