Sub-folder sorting #490
Merged
Sub-folder sorting #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patches were sorted correctly as were categories, but in order to enable sub-folders I construct an explicit child list in categories. I do that before the patch sort and traverse it at menu build time. That category list requires a sort to display correctly. Fixes surge-synthesizer#481
|
on it |
jarkkojs
approved these changes
Feb 3, 2019
|
Thanks for the review @jsakkine. What is it they say about imitation and flattery. I’ll merge this |
baconpaul
added a commit
to baconpaul/surge
that referenced
this pull request
Jul 10, 2019
Sub-folder sorting. Closes surge-synthesizer#481 Former-commit-id: 8d77a6890170cb190848259d2872e36c0bc64fad [formerly e0163d0] Former-commit-id: 5f7c765c6f66d109fc4f690da1443a08efc80d40 Former-commit-id: f7ee2f2a385b87957f747601ba7c066830108c28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patches were sorted correctly as were categories, but in order to
enable sub-folders I construct an explicit child list in
categories. I do that before the patch sort and traverse it
at menu build time. That category list requires a sort to
display correctly.
Fixes #481
@jsakkine a review would be lovely. @esaruoho if you want to test with your patches that would be great. I tested with a pretty deep hierarchy.