Sub-sub-folders of presets are not sorted by A-Z #481
Comments
|
Oh right if categories have colliding names the sort will blow up. Can you rename ticket to that and then we can fix it? |
esaruoho
changed the title
|
clarified ticket :) |
|
@jsakkine FYI I am 99.99% sure this is an error in my submenu recursion code, not in your sorting code. I think I am using natural rather than sorted order at one point for child lists and just need to find that. So my bug not yours. |
|
@baconpaul, Can you take a shot at this? I can review it. |
|
Yeah it's not your sorter. It's my menu maker. I'll get it! |
baconpaul
added a commit
to baconpaul/surge
that referenced
this issue
Feb 3, 2019
Patches were sorted correctly as were categories, but in order to enable sub-folders I construct an explicit child list in categories. I do that before the patch sort and traverse it at menu build time. That category list requires a sort to display correctly. Fixes surge-synthesizer#481
Merged
|
Fix is in. |
|
Will merge once I get a quick review. Thanks for finding this! |
baconpaul
added a commit
to baconpaul/surge
that referenced
this issue
Jul 10, 2019
Patches were sorted correctly as were categories, but in order to enable sub-folders I construct an explicit child list in categories. I do that before the patch sort and traverse it at menu build time. That category list requires a sort to display correctly. Fixes surge-synthesizer#481 Former-commit-id: 9661a5d183197eb2ed7407969cb594123a27431d [formerly c13a481] Former-commit-id: e83c07c6a79f4383ebb7c29f64d3c230ccb124f2 Former-commit-id: b1240d1c2b0d2bc4f1356c3a99409148e4fdb9f7
baconpaul
added a commit
to baconpaul/surge
that referenced
this issue
Jul 10, 2019
Sub-folder sorting. Closes surge-synthesizer#481 Former-commit-id: 8d77a6890170cb190848259d2872e36c0bc64fad [formerly e0163d0] Former-commit-id: 5f7c765c6f66d109fc4f690da1443a08efc80d40 Former-commit-id: f7ee2f2a385b87957f747601ba7c066830108c28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I have a
~/Documents/Surge/3rdparty/folders/presets.fxpsituation.When I go to check out what's underneath
3rdparty- the A-Z sorting is not accurate.Here is a screenshot to illustrate.
expected: a-z is sorted a-z
current result: all over the place.
The text was updated successfully, but these errors were encountered: